My first tribute page, comment on it

Code Feedback
1
2

great work @NatnaelSisay
I think you missed one bullet point or may be there is extra bullet point :upside_down_face:
Overall page looks good + font selection is matching with the subject(tribute page)

Keep up the good work!

1 Like
3

Hey Natnael,

congrats on your first project, great job so far! :clap:

My ideas:

  • all tests pass, awesome!

  • you can get a code validation:

    • HTML: paste your codepen HTML code into the body
    • CSS: paste your whole CSS code
    • you will see one small errors, I think you are able to fix it! :+1:

  • you can increase the readability of your code by:

    1. clicking on the small arrow on the right side of the code box and
    2. clicking Format HTML/CSS

  • when I decrease the width of my browser, the content gets squeezed; this is important for people who read your page on a smartphone:
    Screenshot_2020-09-03_08-20-52

  • like already mentioned, there is a unnecessary empty list item

Keep up the great work,
looking forward to seeing your next steps! :slightly_smiling_face:

1 Like
4

Thank You So much.
I got one problem though, i don’t know how to solve “when I decrease the width of my browser, the content gets squeezed; this is important for people who read your page on a smartphone:”
i would love it if you could give me some hints.

5

Your page looks good @NatnaelSisay. In addition to the preceding comments something to revisit;

1 Like
6