My Tribute Page - Feedback

I have created my first project. Looking to get some feedback.

My Tribute Page

Before this I was learning Java for six months. Everyone told me that HTML/CSS is going to be piece of cake because you managed to slay the tougher one. I though I would quickly learn HTML/CSS and then go back to Java. But It is taking me way longer than expected. The accessibility, multiple sizes of view port, responsive design etc. I am saying this because the second project ‘the survey page’ has given me some real pain.

Hi,
Good work.

Some tips:

  1. Remove </img>, because <img> does not have a closing tag.
  2. Close your </p> element in the footer.
  3. Try to add class to the image to make it responsive. The image will scale depends on the parent element:
#image img {
  width: 95%;
}
  1. Work on lists on smaller resolutions.
  2. If you work in codepen.io mainly you don’t need
    <html><header></header><body></body></html>. In HTML tab you put just what you usually put in <body> section
  3. Keep learning !
1 Like

Try to add this and see how it looks:

#image {
  /* Empty, you are targetting the parent container element here, not the img itself */
}

#image img{
  max-width: 100%;
  height: auto;
}

This will make the image responsive. Thing is, you specified the width of the parent, but not the image itself.

“Before this I was learning Java for six months. Everyone told me that HTML/CSS is going to be piece of cake because you managed to slay the tougher one.”

This can’t be further from the truth, they simply have nothing in common, CSS is NOT easy because it’s huge, and after years of web development you will continue to learn new things in CSS as you face new challenges. CSS is easy if there’s no one else than yourself, because you will writte the CSS that you are comfortable with…But when you get a real world design, you are faced with a LOT of problems that you have to solve with CSS and you will elarn the hard way that CSS is not as easy as it looks, and it’s hard to master. Just take a look at CSS tricks to see how huge it is and how elements are there.

1 Like

hey, well-done on your first project! in regards to the design maybe you can have more fun with it? Just to make it more interesting to look at. Playing around with colour and layout is an option.

p.s i took css for granted but when i actually had to build stuff i realized my mistake, even though it is not a “language” I have learnt to respect it.

1 Like

Thanks for your help in helping me correct my mistakes…I have Implemented all but I did not understand your 4th point.