My Tribute Page: Pauline Black (Feedback welcome!)

Code Feedback
1

Hey guys,

I just completed my first ever tribute page! Please take a peek and tell me your honest opinions.

I want to learn from my mistakes so don’t hold back, I welcome all critique and corrections.

Thank you!
:v:

1 Like
2

Hi @Peaseblossom,

CSS

  • This code is not correct (the center value is no valid):
.icon2 {
...
  float: center;  
...
}

MDN documentation:

Values

  • left
    Is a keyword indicating that the element must float on the left side of its containing block.
  • right
    Is a keyword indicating that the element must float on the right side of its containing block.
  • none
    Is a keyword indicating that the element must not float.
  • inline-start
    Is a keyword indicating that the element must float on the start side of its containing block, that is the left side on ltr scripts and the right side on rtl scripts.
  • inline-end
    Is a keyword indicating that the element must float on the end side of its containing block, that is the right side on ltr scripts and the left side on rtl scripts.

HyperText Markup Language:

  • This code is not correct (the property is color)
.credit {
  ...
    font-color: #ffffff;
}

MDN documentation:

The color property sets the foreground color of an element’s text content, and its decorations. It doesn’t affect any other characteristic of the element; it should really be called text-color and would have been named so, save for historical reasons and its appearance in CSS Level 1.

  • This code not comply with Bootstrap:
<div class="bg">
  <img src="https://media.npr.org/assets/img/2012/06/08/gettyimages_85849850_wide-415835162f057fa03638afe32e26d9e7ed2e820c.jpg" alt="" class "img-responsive" width="1100" height="620" class="desaturate">
</div>

<div class="row">

Bootstrap documentation:

Rows must be placed within a .container (fixed-width) or .container-fluid (full-width) for proper alignment and padding.

This seems error prone:

 <div class="title">1953</div>
        <div class="body">   <-- here

Cheers and happy coding :slight_smile:

1 Like
3

Thanks much for the corrections! I’m gonna brush up on my HTML and CSS for a while longer until I’m 100% fluent.

4

You’re welcome. I really like the design of your tribute page :slight_smile: .

Cheers and hapy coding