My very first survey form

Code Feedback
1

Hello everyone,

Here is my attempt at the 2nd Free Code Camp challenge. Please let me know what you think, any feedback is welcome :grinning: .
Thank you and stay safe!
Holiday survey

2

Hi @alexperezdavies !

Welcome to the forum!

I think your page looks good.

A few things.

You should add the cursor pointer to the submit button.
{cursor: pointer;}

This is not how you write a br tag. Br tags are self closing.
<br></br>

Also, you should not use br tags to create space between elements. Use css instead.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br

You don’t need the doctype and html tags for codepen.
You are missing an end form tag in your html.

Hope that helps!

3

Thank you very much for all the feedback. Really appreciate it!

1 Like
4

One quick question @jwilkins.oboe. What is the best way to apply spaces between elements in CSS without using br?

5

Labels and inputs are inline elements.
So you could wrap the labels around the input and then set the label to display:block; and then use the margin property to create space on the top and bottom

  <label for="name" id="name-label">Name:
  <input type="text" id="name" placeholder="Enter full name" required></label>

label {
  margin:20px 0;
  display:block;
}

You can also create a class and apply those styles to select labels if you want.
https://developer.mozilla.org/en-US/docs/Web/HTML/Inline_elements

1 Like
6

@jwilkins.oboe Thank you!

7

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.