Please critique my Tribute Page, first time coder

Code Feedback
1

Any and all critiques, advice, and/or comments more than welcome. Thank you in advance!

2 Likes
2

Hi,

This looks pretty good! Personnaly I would change the bg-color and color of text because I find beige and black don’t really have an effect in your favor imho. But I’m also a beginner so :] yeah.
You could google some tribute pages to get inspiration and make your design better.

Nice job on using text-indent property I didn’t even know about it.

Nice job and happy coding,
-Tech.

3

Thanks so much! I went with the text color and others based of the central image, but I’ll definitely play around with it and check out some others on google.

Thanks again,
-Ash-

1 Like
4

Good job on your tribute page, Ash! I like how your font color is similar to the skin tone in the image. Design-wise, I think a charcoal background would be better than the deep black. Your red links may not have enough contrast with the background and some users might find them hard to read.

Code-wise, <div id="main"> could be replaced with the <main> to make it more semantic. Then, the page could be broken up with <section> elements.

Sorry, it won’t let me add links to resources. Do a search for color theory and one for semantic HTML5

Keep up the great work!

1 Like
5

It was just my opinion. Seems like peter got a better analysis that sounds like what you told me.

6

Thanks Peter! I’m working on the red links visibility now.

2 Likes
7

Hey this is a really good project!. The only thing I would change is to add and margin on left and right of the text as it is a bit difficult to read that much text in one line.

Here is a good article I found that explains how to achieve this. https://blog.prototypr.io/how-to-set-perfect-line-lengths-for-the-web-528f08f8b344

1 Like
8

Awesome! Thanks for the advice. Exactly the type of stuff I need to learn and understand.
Thanks again Jermur