Please give me feedback on my survey

Code Feedback
1

I finished the survey a while ago and forgot to ask for feedback.
Any feedback you may have is appreciated :slight_smile:
https://codepen.io/michelz/full/vomLWb

2

Hi @michel-z, your form looks okay. A few things you may want to revisit;

  • Review this document on the <label> tag
    https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
    Pay attention to the ā€˜Accessibility Concernsā€™ section and the ā€˜Headingsā€™ subsection under that. You donā€™t want your heading to be a label, rather a fieldset with a legend.
  • Also, make it so the user can click on the label, not just the radio button and/or checkbox. You can do away with the paragraph tag when you code your radio buttons and checkboxes as groups.
  • Change the cursor to a pointer when hovering over the Submit button
  • An error comes up if the user only puts in one name. The error reads ā€œPlease match the requested formatā€ but there is no indication of what that format is. If you require users to put in a first name and last name you can have a required field for each or, give the example in the placeholder text.
  • Take those <br> elements out and use margin and/or padding in CSS to style your form.
3

There is a responsiveness problem, forms do overflow the blue container at smaller screens. Set a min-width inside #survey-form to fix it :slight_smile:

4

I addressed your points. Thanks especially for the <label> comment. I was struggling with that at first and at some point I just said ā€˜good enoughā€™.

The placeholder text actually says ā€œYour full nameā€, but Iā€™ve changed the label now from ā€œNameā€ to ā€œFull nameā€ to make sure itā€™s clear enough.

1 Like
5

Fixed it. Thank you :slight_smile: