Hi everyone)
Could you please give me feedback about the Tribute Page? The most horrible thing for me here is the <li>
tags. Thank you in advance. Have a great day)
Hi everyone)
Could you please give me feedback about the Tribute Page? The most horrible thing for me here is the <li>
tags. Thank you in advance. Have a great day)
HI @JerryTheQuad !
Congrats on finishing the first project!
Here are my thoughts.
You are currently passing 9/10 tests.
Read the full error message to fix the issue.
Please validate your email so we can see the full view.
Review the lesson on giving links meaningful names.
Wikipedia page is not that accessible.
For codepen, you do not need to include any of the doctype, html or head tags.
That is already provided for you.
You can remove these div tags because you are not using them here.
<div>
<h3>If you want to find more about Viktor Tsoi, check out his <a id="tribute-link" href="https://en.wikipedia.org/wiki/Viktor_Tsoi" target="_blank">Wikipedia page</a>.</h3>
</div>
Lastly, you have a lot of repetition here
display: flex;
flex-direction: column;
Instead of applying those same properties to different ids it would be better to create a class and assign that class to the html elements you want to share those styles.
For example:
.flex-container {
display: flex;
flex-direction: column;
}
Hope that helps!
Hi!)
Thank you so much for so many tips. I knew I had some mistakes here, but I didn’t know there were so many of them. Thank you for the advices, especially with the flex repetition.
Have a great day)
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.