Hi everyone!
I finally finished my Product Landing Page for an imaginary online reading service. It would be so so helpful if I could have feedback on this!
Thank you already!
Hi everyone!
I finally finished my Product Landing Page for an imaginary online reading service. It would be so so helpful if I could have feedback on this!
Thank you already!
Hi there,
To me everything looks great. It seems you have a good grasp of responsive design. The only two minor suggestions that I have are:
Apart from that, great job. Maybe professional web devs would find some more suggestions. Have a great day)
Hi @JerryTheQuad!
Thank you so much for your feedback and for taking the time to look at my page! The things you pointed out make all the sense, Iām going to change those!
If I may ask, for the footer part, do you know if there would be a better way of centering the text and styling the button to the right without having to insert the empty div in the html? It was the only way that occurred to me that actually worked but Iād be interested to know if thereās a more efficient way! Thank you!
Hi there, @ines-violin)
Sure, I can help you, although Iām not a pro web dev in any way. It turned out to be simple:
Delete the span element;
Change these two lines in your footer CSS:
grid-template-columns: 1.2fr 1fr;
justify-items: end;
Works like a charm for me. Maybe play a bit with the first fr or leave it like that. No need for the empty span anymore!)
Have a great day!
Hi @JerryTheQuad! Thank you for your help!
Iāve just tried your suggestion and it works perfectly for larger screens but when I narrow it down then the text gets placed more towards the left instead of centered. But itās actually alright, probably Iām just being too picky
Thank you again and you too have a great day!
Hi there,
Iām glad that my solution helped you, even if a little. Iāve checked the code with Google DevTools and the text seems to be alright. Could you please send the screenshot with the text being more to the left?
Well, even if itās the case, I could suggest adding this to your @media:
@media (min-width: 600px) {
footer {font-size: 0.8rem; grid-template-columns: 1fr 1fr;}
Sry if you wanted a more elegant solution to the Ā«empty spanĀ» problem. This is the only thing I can suggest for now ā twicking the media part until you get the text perfectly centered.
Have a great day!)
The site looks pretty good.
Since you have some design skill, I would encourage you to try implementing a Hero Image, Either with your pre-exsistng Text, or some other text.
Also: Tolkienās book is Spelled āHobbitā.
Hi @JerryTheQuad!
Thanks for your message!
So Iāve just tried it and somehow to me it still seems more towards the left. Iāll include the screenshot below. Itās pretty centered, the difference to the left is actually really tiny. Iāll play around with it until I find the perfect center
Thank you for your help and have a nice day!
Hi @ALLESS!
Thank you very much for your message and for taking the time to check my project! Iāll try to implement the Hero Image and will update the result here.
Also thanks for much for pointing out the typo!
Hello!
Sorry for the delay, Iāve finally had a bit of time to implement the Hero Image. I think it turned out pretty nice. What do you think? Would love to have your thoughts on it!
Thank you!
It is Good Ines. I think youāre right, and it turned out well. I also love that you added Marquez on the list. I realize that āSolitudeā is more famous, but I prefer āLove in the time of Choleraā.
Hi @ALLESS!
Thanks for your feedback and for the book recommendation! I havenāt read 'Love in the time of Choleraā but I will definitely give it a try, it has a very promising premise!
The book is very divisive. It has topics that are difficult for some people, However the language is Exquisite.
https://www.goodreads.com/book/show/9712.Love_in_the_Time_of_Cholera
Good Job completing the Project.
Thank you!
And Iāll definitely read this book, Iām quite intrigued! Also itās been ages since I last read Marquez!
wow its good website illl rate it 3 out of 5
smaller screen also good
do more projects and you can gain more knowledge.
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.