Project feedback about tribute page

Code Feedback
1

Just completed my first project. I’m open for your feedbacks and recommendations.
Here’s the link: https://codepen.io/florence-ocon/pen/YzWBEGv

Thank you in advance

1 Like
2

@FOcon That looks very good! One thing I noticed though is that you don’t have the tests going on your page. To do that at the bottom of you html file do this.

<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
</body>

You should add that script tag to the very last line of your body tag. You were failing one test when I ran them. Look over it one more time and try to fix the test! Happy Coding! :smile:

3

Hey @FOcon!

I think your page looks good.
A couple of things.

Hope that helps!

4

Your page looks good @FOcon. Some things to revisit;

  • Make the project from scratch, with your own code, style and content. Don’t take code from the sample project.
    • The projects aren’t just another challenge. Each one is meant to be a significant step in your progress. Every project you do will require research, planning, trial and error, and strengthening your skills beyond what you gain from the incremental challenges.
  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
    • This page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.

There are additional comments that could be made but it’s best if you create an original page first and then ask for feedback.

5

thank you so much for your input

6

thank you so much for your input :smiling_face_with_three_hearts:

1 Like
7

I made some changes hopefully I get it right.
Here’s the link : https://codepen.io/florence-ocon/pen/YzWBEGv

Thank you guys

8

Remember to leave the test script in your html page.

You still need to pass test no.6.

User Story #6: I should see an element with a corresponding id="tribute-info" , which contains textual content describing the subject of the tribute page.

9

Thank you once again @jwilkins.oboe. I revised it again hopefully I get it right. Hera’s the link: https://codepen.io/florence-ocon/pen/YzWBEGv

10

@FOcon, things to revisit;

  • As mentioned a few times previously, keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    • If you want multiple paragraphs then use multiple paragraph elements.
  • Make the project from scratch, with your own code, style and content. Don’t take code from the sample project.
11