Please rate my product land page. Thanks
Your page looks good @iffi_nice. Some things to revisit;
- Keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>
)- The test script, with all tests passing, should be included when you submit your projects.
- Your page passes 12/16 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
- Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
body
element in the HTML editor. (No need to include thebody
tags). For anything you want to add to the<head>
element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.- For instance links to fonts go in the box labeled ‘Stuff for <head>’
- Run your HTML code through the [W3C validator] (The W3C Markup Validation Service). (I made you aware of this previously. Keep it in your toolbox and use it)
- There are HTML coding errors you should be aware of and address.
- Since copy/paste from codepen you can ignore the first warning and first two errors.
- Do not use the
<br>
element to force line breaks or spacing. That’s what CSS is for.- Reference MDN Docs
- You can nest multi-line
<code>
snippets in<pre> </pre>
tags in HTML to preserve whitespace and line breaks.
Or skip thepre
element and do the following in CSS;
code {
white-space: pre-line;
}
- Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
- “click here” is not accessible
Since you’re asking for feedback I’m moving this to an appropriate subforum, the #project-feedback subforum
(I’ve done this for you before)
On a side note I notice none of your projects pass all the tests. If you’re working towards the RWD certification they’re going to need to.
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.