Product Landing Page Rate my page

Code Feedback
1

Please rate my page and comments thanks. Bellow is code pen link:

https://codepen.io/iffi_nice/pen/RwoNrJY

Thanks :slight_smile:

2

Your page looks good @iffi_nice. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 5/16 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address. (This is HTML5 so you don’t want to be using an obsolete attribute.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s). (That is not the proper way to comment in CSS.)
    • (The one for HTML misses things which is why I recommend W3C)
  • Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
    • You learned to do this when coding the survey form

Since you’re asking for feedback I’m taking the liberty of moving this to a more appropriate subforum, #project-feedback

1 Like
3

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.