React API call error handling

I’m building a weather app and if the user inputs a non existent city name, no changes should occur in the app and the page should just throw an alert saying “city not found”. I tried doing this by attaching .catch(err => alert("City not found")), which was throwing the alert but the app was also crashing because the state was being set to an incompatible object. So now I added an if - else statement, which appears to do the trick, but I’m not sure if this is the best way to handle this. Here’s the link to full code

function getData(e) { // set state after searching 
   let name =;
    if (e.key === "Enter") {
  .then(response => response.json())
  .then(data => {
     if (data.cod !== "404") {
     let date = getDate(data.dt, data.timezone)
     setToday(prev => ({...prev, "day": date.slice(0, 3), "date": date.slice(5, 16)}))
     } else {
       alert("city not found")
  .then(response => response.json())
  .then(data => {
      if (data.cod !== "404") {

I don’t think I can achieve what I’m doing there without calling it twice. On the first call I get the data, then call the getDate function and use dt and timezone from data to get the date of the city being searched, and then I update today by calling setToday again and adding two additional keys - day and date.
Alright, I will put the second fetch in the if block. But is this an acceptable way of handling errors? I always thought a .catch was a must.

Thanks. I have another issue right now. I just opened the app on my phone and it crashed after I typed a city name and pressed “search” on the keyboard. What could possibly cause this?

It just disappeared, which is what normally happens in Codepen when React crashes because of some internal error in the code. But it works fine on PC. Could you please try opening the link on your phone?

I just noticed I had onChange={changeBg} on my input because I used that to console log some state values, but now I removed it from input completely. I checked the replit link and it looks like the issue arises on any key press. As for the other two errors, do you mean this? DevTools failed to load source map: Could not load content for chrome-extension://gighmmpiobklfepjocnamgkkbiglidom/ System error: net::ERR_FILE_NOT_FOUND
Also, can you point me in the direction of fixing these errors? I’m just not sure where to even look.

I changed it to onKeyPress and the issue seems to be resolved. Thank you. So could you please tell me what the other two errors might be? I’m just not seeing anything in the console other than that message in my previous reply.

Considering the keypress event is deprecated it might be better not to use it. Can’t you use onKeyUp instead? Or maybe switch to a form submit so you do not keep running the function on each key press (or maybe at least debounce it).

Not sure what the other errors are, other than the 404 you inviability will get with an invalid name.

Thank you, I’ll do that, but Randell said "You have at least two other errors showing in the browser console you also need to resolve.". I would really like to know what those errors are. I’m not seeing anything other than DevTools failed to load source map:

Great, thank you. One more question, are you getting a warning asking whether you want to continue when you hit enter in the input field? I’m wondering if it’s the way that I have my code set up that causes this, or it’s just a warning that CodePen itself issues.

Here’s the reddit post I made about the warning issue, I attached a video showing it

Yes, I was intending to use that one initially, but it requires a subscription.

Oh alright, thank you. I just figured since it’s a free API, even if someone uses it and goes over the daily call limit, it’s not a big issue. But I’ll keep that in mind next time.

Yes, I plan to include it as a portfolio project, but I’ll turn it into an actual app and I’ll clean it up then, I use CodePen just to get the functionality. Btw, do you think it’s a decent project to have on my portfolio if I’m applying for a Front End internship?

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.