Review and provide feedback for Landing page

Code Feedback
1

Please review my Landing Page and provide me feedback so i can correct it.

https://codepen.io/MadanSinha/full/poEQpzM

2

Your page looks good @madansinha. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    • This is in reference to the form, not the poem.
  • overflow: hidden; will completely hide anything that extends outside its container element horizontally. It’s recommended to not do this, and refactor your CSS to be more responsive - otherwise it is possible for your site to appear to be missing content.
  • Don’t be afraid to be descriptive with class and id names. It’ll be more semantic for yourself, and others who read your code. For example, if you have several cryptic class names or id's that make sense to you now, they may not a year later and probably will never mean anything to other people.
  • .a, .b and .c in CSS and their hover selectors are all identical. There’s not need to have them separated and would look better if they were together. Easier to maintain because you’d only have to make changes in one place rather than three.
1 Like
3

@Roma I really thankful😊 for your feedback, for future I am trying to take care of these points .

1 Like
4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.