hi world
i have finished my 2nd project and I was gonna submit but before that i wanted to get some feedbacks.
It’s kind of hard to see in editor view. You need to verify your email on codepen for others to view it in full screen.
how about know.
@Aben, some things to revisit;
- Verify your email addr with codepen so people can see your page full view.
- I asked you to do this when you requested feedback on your survey page. Please, verify it.
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
body
element in HTML. (No need to include the body tags). For anything you want to add to the<head>
element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.- You have elements placed incorrectly. Everything the browser renders belongs inside the
body
element. Theheader
element belongs in thebody
element. Thetitle
element belongs in thehead
element.
- You have elements placed incorrectly. Everything the browser renders belongs inside the
- Run your HTML code through the W3C validator.
- There are HTML coding errors you should be aware of and address.
- The
fieldset
element is meant to group like parts of a form. It should encompass the entire form. - User’s should be able to click on the label to select, not just the radio button / checkbox.
- For the age input your code has a
max
attribute set to 5 and amin
attribute set to 99. I can’t think of a number that falls within that range. - Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
- The one for CSS is good. Use it, there’s something to clean up.
- The one for HTML misses things which is why I recommend W3C
how about know.
Absolutely nothing has changed that I can see.
You haven’t verified your email address.
All the issues noted above are still there.
I have added some otherthings
Please help me help you. I don’t know what “otherthings” is or means.
You have now verified your email addr with codepen. Thank you. Be more verbose in what you tell me.
All the other issues noted in my first review are still present and should be taken care of. If you’re making changes to your pen be sure and click the “save” button so the changes take affect.
Also, I don’t normally comment on someone’s design choices but there are some things you should revisit with yours. I don’t think we should go into that yet until you take address the more important issues that have already been noted.
Ok I’m sorry
how about know
@Aben. What have you done to address the issues I noted in my first response to you? I don’t see anything that’s been addressed or corrected.