Tribute Page-opinions and suggestions?

Code Feedback
1

Hello everybody,
I just finished my first project ever here on freeCodeCamp, looking foward for your opinions and sugestions.

2

Your page looks good @cristeaionut96. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    Mainly mentioning because you have elements out of order. Everything the browser displays belongs in the body tags. Review this for an understanding of the HTML boilerplate tags.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address. Clean your code with the first feedback and this will be a no-op
      Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
      (The one for HTML misses things which is why I recommend W3C)
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “this wikipedia page” is not accessible

This is a suggestion. You don’t have to do anything if you don’t want to. It’s hard to read the timeline with it being centered. The eye wants to start from the beginning on the left, not have to search around. Maybe try left aligning to see if you think it looks better too.

3

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.