Tribute page Project challenge

Code Feedback
1

What is your hint or solution suggestion?

Hi everyone. I have just created my first project…Tribute page. Please help me to make it responsive and any suggestion or criticism is welcomed.
https://codepen.io/Kay-More/pen/LYbVVmg
Thanks in advance

ute Challenge: Build a TribPage

Link to the challenge:

2

The best way to do this is to use a narrow-first approach. Narrow your browser as skinny as it will go and style the page so it looks good at that skinny width. This will be your base CSS. You will not use any CSS break points here.

Then after you have the above looking good you can gradually widen your browser until you have enough horizontal space to rearrange elements for a wider view and add your first break point there (using min-width and em units). Then add the styling for the wider view under that break point. Repeat as necessary.

3

Welcome to the forums @5443. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 5/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • Mentioning because you have an element that doesn’t belong. Everything the browser renders belongs in the body element. The title element would not appear in the body element. Review this for an understanding of the HTML boilerplate tags.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
    • “read more here” is not accessible

And as mentioned, use the narrow-first approach as an aid to making your page responsive.

4

Thank you very much. I’m on it

5

Thank you very much for taking the time to review my tribute page and advising me on issues I should work on. I will fix my tribute page and re-send it. Much appreciated

1 Like
6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.