Tribute project - looking for feedback so I can improve

Code Feedback
1

Any feedback would be appreciated! Thank you!
[https://codepen.io/ccc5909/pen/MWojOOV?editors=1100]

2

It is good. One suggestion I would make would be to make it more responsive. Bootstrap is an easy way to make it responsive.

1 Like
3

Hi @cathy59,

Some comments:

** HTML

  • Do not use <br> to increase a gap:
<br>
<br>
<style <link rel="preconnect" href="https://fonts.googleapis.com">

MDN documentation:
<br>: The Line Break element - HTML: HyperText Markup Language | MDN

Related to the above, there is the idea/best practice of semantic web:

Semantic HTML refers to the traditional HTML practice of markup following intention, rather than specifying layout details directly. Layout details are left up to the browser, in combination with Cascading Style Sheets.

** CSS

  • Line 11:
Unexpected unknown property "align"
  • Line 60-61:
Unexpected unknown property "left-margin"
Unexpected unknown property "right-margin"
  • You have a variable number of spaces, new lines , ect. (inconsistent formating).

Codepen has a feature that lets you analize HTML,CSS and JS code. It also has a feature that keep the formating consistent.

Cheers and happy coding :slight_smile:

1 Like
4

Thank you for taking the time to give me feedback, I appreciate it. I have so much to learn!

1 Like
5

Thank you I will look up Bootstrap.

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.