Why are my else if statements not working

JavaScript
1

Why are these not working the code works on the first if statement then stops working with no error messages in the console.


let normalTreeChopped = 0
let patch1 = document.getElementById("patch-image-1")
let patch1Src = patch1.getAttribute('src')

let patch2 = document.getElementById("patch-image-2")
let patch2Src = patch2.getAttribute('src')

let patch3 = document.getElementById("patch-image-3")
let patch3Src = patch3.getAttribute('src')

let nonePath = 'assets/img/woodcutting/trees/none.png'

function startTreeGrow() {
	if (woodLevel >= 1) {
		let normalTreeChance = Math.floor(Math.random() * 45)
		if (normalTreeChance == 33) {
			if (patch1Src == nonePath) {
				document.getElementById("treeName1").innerHTML = "Tree"
				patch1.src = 'assets/img/woodcutting/trees/tree/tree1.png'
			} else if (patch2Src == nonePath) {
				console.log("2!")
				document.getElementById("treeName2").innerHTML = "Tree"
				patch2.src = 'assets/img/woodcutting/trees/tree/tree1.png'
			} else if (patch3Src == nonePath) {
				console.log("3!")
				document.getElementById("treeName3").innerHTML = "Tree"
				patch3.src = 'assets/img/woodcutting/trees/tree/tree1.png'
			} else {
				console.log("NOPE!")
			}
		}
	}
}

setInterval(startTreeGrow, 1000)
2

hi there, is this an fCC challenge? Can you post a link to it?

3

No it’s not. Its just something I’m stuck on.

4

maybe you can try adding some log statements?

for eg. if this if is not executing then I would add a console.log right above it
console.log("normalTreeChance = " + normalTreeChance);

Eventually you will find a log that is unexpected and can work from there.

5

yeah, the else ifs are broken

6

can you log patch1Src patch2Src etc?

7

image
image978×429 17.4 KB

patch1 says tree1 as src because The program was running for an while if it was not it would’ve been none.png

Here is my HTML if you’re curious

      
            <!--Woodcutting-->
            <div id="woodcut" class="tabcontents">
                <h1 style="text-align: center;" class="titleSkill">Woodcutting</h1>
                <h3 id="levelWoodcut" style="text-align: center;">Woodcutting Level: 1</h3>
                <div class="grass">
                    <span>
                        <span class="path-margin desc-patch"><p id="treeName1" class="treeNAME">None</p><p id="timeleft1tree">(00:00:00)</p></span>
                        <img class="patchO-grass" id="patch-image-1" src="assets/img/woodcutting/trees/none.png">
                    </span>
                    <span>
                        <span class="path-margin desc-patch"><p id="treeName2" class="treeNAME">None</p><p id="timeleft1tree">(00:00:00)</p></span>
                       <img class="patchO-grass" id="patch-image-2" src="assets/img/woodcutting/trees/none.png">
                    </span>
                    <span>
                        <span class="path-margin desc-patch"><p id="treeName1" class="treeNAME">None</p><p id="timeleft1tree">(00:00:00)</p></span>
                       <img class="patchO-grass" id="patch-image-3" src="assets/img/woodcutting/trees/none.png">
                    </span>
                 </div>
            </div>

(sorry of the formatting) don’t mind the time left

1 Like
8

what if you do this

console.log(patch1Src == nonePath);
console.log(patch1Src === nonePath);
console.log(patch1Src.equals(nonePath));
1 Like
9

image
image995×371 13.9 KB

10

so true means that the if statement did fire.

Can you add a console.log inside this if? We know it is running, but maybe you are just not seeing the results?

11

the if staement works fine its just the else if statements that don’t work
Here is a visual

image
image1849×772 72 KB

The nones are supposed to be trees if the else if did not work

12

Sorry, i keep misreading you.
Can you do the above for patch2Src and patch3Src then?

13

true and true

image
image1002×66 1.03 KB

14

can you log them all at the same time?
including patch1Src first, then patch2Src etc.
I want to see what they are simultaneously

15

Is this what you want?

image
image978×160 3.67 KB

That’s weird because the tree started growing in the first patch it’s supposed to be assets/img/woodcutting/trees/tree/tree1.png right now it displays assets/img/woodcutting/trees/tree/tree1.png but the console says it’s not.
image
image1859×763 71.3 KB

16

yes so you can see that they are all true
this means the first if will fire which is why no else will fire after that

17

Red the top I juts updated it. lemme try changing patch1.src to patch1Src when I change the image to a tree

18

so it works now but the images are nto showing up Ill fix that onmyown in the meantime I found some more naming errors like treeName3 was not even there

19

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.