A tribute to First Lady Michelle Obama

A tribute to First Lady Michelle Obama
0

#1

Hi to everyone at FCC.
I’ve completed my first project with everything passing. I would be so pleased to get feedback for it.
here’s the link https://codepen.io/Daniel-CP/pen/jvMeGz


#2

Hello,

This looks good so far, there is a couple of things I would recommend. Firstly, the last test isnt seeming to pass, so you need to center the image. You can do that by adding margin: auto to the css for the image. Id also recommend that you replace the image for one without a watermark, and maybe add some more css to give the page a little bit of flair, possibly shifting the list so it starts more to the left. But otherwise, it looks good!!


#3

This is the url with your suggestions . https://codepen.io/Daniel-CP/pen/jvMeGz
please let me know what you think, also about empty rulesets am I missing something here?


#4

Hello! You can use this

*{
  margin: 0;
  padding: 0;
}

to improve your design. This way you won’t have white spaces on borders :wink:


#5

Also, here are some improvements to your code:

  1. Add this:
#tribute-info ul{
  margin: 0 auto;
  width: 50%;
}
  1. And delete paddings in ul styles:
ul {
  text-align: justify;
  //no padding
}
  1. For better readability:
li{
  margin-top:1%;
}

and

#img-caption{
  margin: 1% 0 0 1%;
}
  1. You wrote “claas” instead of class in this section:

<li class= "li">Michelle Obama, whose full name is Michelle LaVaughn Robinson Obama was born on January 17 1964</li>

Hope that helps!:wink::+1: