Feedback for JRR Tolkien Tribute Page

Code Feedback
1

Hi everyone,
I made a JRR Tolkien tribute page as my first responsive web design project.
It passed all the tests but I’d like some human feedback - is the code ok, does it follow good practices?

I just started out on web development and my aim is to write code that is as clean as possible. Any suggestions are welcome!

https://codepen.io/lucydeetz/full/MWjvzNy

2

Welcome to the forums @LucyDeetz. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links.
  • on a side note, while both the <b> and <strong> elements render the same there is a semantic difference between the two

I don’t often comment on styling because it’s what the person chose but since the dates in the timeline are bold, why not get rid of the bullet points.

1 Like