Feedback for Technical Doc

Code Feedback
1

Really appreciate any feedback. I did originally have it with a hidden scrollbar which looked better but realised if you didn’t use a phone or touch screen you wouldn’t be able to scroll.

2

Your page looks good. I like very much how you used gradients, it gives to your page a fresh look.

Some things you should maybe consider:

  1. your page isn’t responsive enough and your main-section disappear around 815px width.
    capture_20201011151248603
    capture_202010111512486031000×1604 65.4 KB
  2. maybe it’s a matter of taste but I think there is to much padding around your anchors.
  3. when you run the FCC script, it says you didn’t pass the test. (13/16 User stories achieved)

Happy coding! :slightly_smiling_face: :+1:t2:

1 Like
3

Thank you.

I actually had it all passing then changed something and broke the whole page. It should be responsive now (hopefully).

I’ve also reduced space between anchors as suggested.

Edit: I take that back. Had it working perfectly but now on mobile view there is a massive gap between navbar and first section. Going to have a break cause I’m pulling my hair out lol

Edit edit: Seem to have fixed it.

4

Your page looks good @rsheppard83. Some things to revisit;

  • Make your page responsive. There’s a horizontal scrollbar on smaller screens.
    • Remember, the R in RWD stands for Responsive
  • There are some code elements where the sample code can be on multiple lines the way a user would normally write it yet you’ve kept it on one line.
    • Hint: nest multi-line <code> snippets in <pre> </pre> tags in HTML to preserve whitespace and line breaks.
      Or skip the <pre> tag and do the following in CSS;
code {
  white-space: pre;
}
5