Feedback requested!

Code Feedback
1

Hi guys! I just finished my tribute page. I was just wondering - are you guys writing your code from memory or using the code of the example? I don’t think I could sit down and just go for it off of the top of my head because I can’t remember everything. Anyway, with that said… any feedback? I’ll take it even if it’s to tell me that I need to go back and memorize everything, because I definitely just altered what was given to me in the example and added the quote style that I found on Google.

https://codepen.io/zg912/full/LYpzEmZ

1 Like
2

its good, very clean, nice job.

And dont worry about coding from memory, i follow quite a good number on twitter even they need to google to remind themselves about certain form structures and such…

its always a case of, if you dont use it regularly, it drops out your head! but dont worry about that, as you’ll always have a sort of reference point, if you know what i mean?

2 Likes
3

I really like the simplicity of the page design. Beautifully made.

Well done.

5

Welcome to the forums @zg912. Your page looks good. Some things to revisit;

  • An id should be unique within the document. You’re using the same id twice.
    • Regarding that, anything in the head element cannot be styled with CSS so there’s no point in giving the title element an id
  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
  • When using codepen it only expects the code you’d put within the <body> </body> element in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Don’t use <br> to force spacing. Use margin and/or padding in CSS.
  • Review the lesson about giving meaningful text to links.

If you know how you want your design and write it out on paper that will help when you start writing your code. If you forget something it’s easy enough to look up. For instance you say, “I want a list but forget how to do that”. You open up a tab with Google and type in “html list” and hit enter and Bob’s your uncle.

1 Like
6