First FreeCodeCamp project

First FreeCodeCamp project
0

#1

Guys I developed a tribute project.
Click on link below :
My Project

Please give feedback and suggest me so that I can improve it.
Thanks in advance…:slightly_smiling_face:


#2

@sgstarade This looks great! I like your font choice, your HTML markup is clean and easy to read, and your CSS is DRY and to the point. Well done.

I think you may want to modify the alt attribute in this code:

<img src="http://www.techmaniya.in/wp-content/uploads/2016/03/stevejobsmotivation-1.jpg" alt="Steve's famous quote">
<p id="caption">The famous quote which touches our heart every time we hear it.</p>

I feel like a person using a screen reader will want to know what the quote is, rather than that it’s “Steve’s famous quote.” Here’s a link that discusses this more: http://webaim.org/techniques/alttext/.

I try to avoid inline styles like <em> whenever possible. Here’s a good discussion about the separation of concerns: https://www.thoughtco.com/avoid-inline-styles-for-css-34668461.

Even though it works and it’s handy, styling IDs with CSS is sometimes frowned upon. Here’s something to read about that if you’re interested: http://screwlewse.com/2010/07/dont-use-id-selectors-in-css/1


#3

@camper Thanks. It is really helpful. As a beginner, you expect experienced people to guide you. Here you are.
I would improve on the points you mentioned.