Have PR for FCC but no reviewers

rigo205 · May 20, 2023, 6:07am

How do I get reviewers from FCC team?

github.com/freeCodeCamp/boilerplate-project-timestamp

space in JSON example removed

freeCodeCamp:main ← will-s-205:fix-typo-in-JSON-example

opened 05:49AM - 20 May 23 UTC

will-s-205

+1 -1

Checklist: - [x] I have read [freeCodeCamp's contribution guidelines](htt…ps://contribute.freecodecamp.org). - [x] My pull request has a [descriptive title](https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=prepare-a-good-pr-title) (**not** a vague title like `Update index.md`) Closes #XXXXX Hi everyone. This is my first Pull Request on a repository that is owned by the FCC team. I'm very happy to be here and I want to thank everyone for making people's dreams come through. As for my PR, I guess it's just a typo but it took a good chunk of my time to understand that JSON in example doesn't require to have a space between pairs. And because I'm a "genius" I've of course tried to reproduce this space in my JSON output. By any chance, can we make it without space? Thank you so much!

bbsmooth · May 20, 2023, 6:28am

It looks like you just created this PR less than an hour ago? I think you need to give a little more time. It’s almost 11:30 PM where I am. Probably a lot of reviewers sleeping right now

rigo205 · May 20, 2023, 6:38am

Thank you so much! Seems like you have CA time )

JeremyLT · May 20, 2023, 3:04pm

It’s better to make an issue before making a PR. I don’t understand why this change is required?

lasjorg · May 20, 2023, 4:14pm

How is the white space significant here?

An API and its response do not use formatting for anything. Formatting the response is for human consumption, it has no bearing on the actual response or how you use it.

rigo205 · May 22, 2023, 5:03am

Yeah you right. Didn’t know that it’s required to create an issue first. I thought I’m helping. Don’t worry I will close this PR right away

JeremyLT · May 22, 2023, 12:04pm

Issues aren’t mandatory, but they are really helpful and I recommend them. They are a chance for everyone to agree if there is a problem and how we want to fix it.