Just finished the first FCC project (tribute page)

Code Feedback
1

I’m seeking feedback from anyone really (it’s nice even to get a second opinion) for my first coding project ever (I know it’s probably really inefficient for what I made but still sorta weirdly proud of it). I tried giving it some character with some terrible jokes and wording which, hopefully, won’t upset anyone. I also tried to make it look relatively nice on both a phone and a laptop. The latter I sort of shoehorned in at the end after I realised it looked terrible on my phone (it might still be a little off due to the list though).the code and the page

1 Like
2

Welcome to the forums @conFuchsian. Your page looks good. Some things to revisit;

  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links.
  • Start with the narrow view (mobile) design first and then work your way wider, adding breakpoints where needed for the wider design.

On a side note, the mobile view is very narrow. Maybe have the pros on top and the cons just below it for easier reading.

2 Likes
3

@conFuchsian, @Roma gave me a lesson there on readability, I thought he meant the links don’t work…thank you @Roma.

To answer you about the page quality, I say you did it justice and I as a fellow amateur writer loved the wordplay and jokes, “BAE” killed me, I thought you were linking to a photo of a celeb or something! :rofl: Good job and keep coding, I think you will enjoy it.

1 Like
4

Thank you for constructive criticism Roma! I’ll make sure to fix these issues before moving on. I really was convinced I got the viewport for the phone version right since it showed me a top down list on my phone, will have to remember to bump it up a bit higher in the future.

1 Like
5

Honestly as long as someone else enjoyed it, that’s good enough for me :D.

1 Like