Landing Page (Feedback)

Code Feedback
1

Have a look at my product landing page. Any feedback is welcome! :smiley:
https://codepen.io/MauriSg/full/OJXBZvZ

4 Likes
2

Hey @msalas2199!
Your page looks awesome!

Your test mark is 15/16.
The image not loaded for me.
There is too much space between video and pricing.

Please make these changes
That’s my Feedback

Thanks and Happy Coding :grin:

3

Hey @msalas2199!

I think your page looks good.

  • You are currently failing one test.

  • img tags need an alt attribute. It also doesn’t load because there is an issue with the google drive link.

    <img src="https://drive.google.com/uc?export=view&id=1D2df3aIC-M8YidV-22iuBbIQSVT5TNaR" id="header-img" href="#">
  • there is a lot of space between the about section and price section.

Hope that helps!

1 Like
4

Hi @msalas2199

I really like your page, it brought back wonderful memories of our honeymoon in Mexico (nearly 9 years ago now, wow).

I agree with the comment that there is too much space between the video and the prices, but apart from that it all looks good to me.

Saludos,
Craig.

5

One of the best landing pages on fcc

1 Like
6

I know :sweat: but I’ve tried everything and I don’t know why it doesn’t work.
It’s the nav-link class, but like I said I don’t know why it’s not working when it’s very similar to the sample code.

What image is not loaded? The logo?

7

Yes, the logo.

A_Pen_by_Mauricio_Salas
A_Pen_by_Mauricio_Salas1092×720 1.15 MB

For pricing and video
inline 252 in the CSS section. padding-bottom

8

Oh okay, how can I solve it?
The pricing and video is already solved, thanks :smiley:

9

Now logo clear and fine.

1 Like
10

Wonderful landing page, I really liked you work. Good luck.

One point, I want to add is, the transparency of the header is too high.
If the site is scrolled down, I see that the text in header overlaps with the text from other sections.

fcc

Thank you.

1 Like
11

Fixed it. Thank you for pointing that out :smiley:

12

Your page looks good @msalas2199. Some things to revisit;

  • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 14/16 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.