My First Portfolio Website (Updated)

Code Feedback
21

It looks good @Lafen. Some things to revisit;

  • Your page passes 9/12 user stories.
    • The test script should be included, with all tests passing, when you submit your projects.
  • Run your HTML code through the W3C validator.
    • You’re using an obsolete attribute
22

Nice Portfolio website. Keep at it. It looks nice and clean.

1 Like
23

I love the design and the idea .
keep working , great work!

1 Like
24

Thanks a bunch for your feedback.

I rectified all the issues you mentioned. I removed all obsolete attributes and the HTML code is now validated.

The test script is included in the document but commented out. I don’t know if I can let it be that way, please let me know. Also, all tests are now passing as shown on the screenshot below.

screenshot
screenshot1920×1007 55.3 KB

1 Like
25

Hello @Lafen . I’ve created a video with some feedback on your project https://youtu.be/s1N-ybGso_M. hope you like it :slight_smile:

1 Like
26

Thanks for taking out time to review my project. I appreciate it :heart:

1 Like
27

No problem at at! :smiley: Hope it’s helps :wink:

1 Like
28

Yeah, it does!

I just completed the Mardown Preview project. I tried as much to make it elegant. I’ll appreciate your feedback

29

Hi,
when I divide by “zero” in your calculator, it displays “infinity”, that’s not true for sure. And sometimes, when I click on x^y button, it displays undefined instead of the “^” symbol. Good luck fixing bugs, that’s part of the job I assume :slight_smile:

30

Hello @Dorfieeee,

Thanks for your feedback. I’ll fix the bugs in the calculator and thank you for letting me know it had bugs.

31

you made with github themes or all coded yourself?

32

All coded from scratch…

33

@Lafen
hi, I can put in two decimal points into your calculator :thinking:

34

Hi @tommytucker,

Thanks for notifying me on other bugs in the project.