I think everything is correct, but just in case I’ve missed something, I want some feedback on my project. Thanks in advance!
Your page looks good @RamiLT. Some things to revisit;
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
bodyelement in the HTML editor. (No need to include the
bodytags). For anything you want to add to the
<head>element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
- Run your HTML code through the W3C validator.
There are HTML syntax/coding errors you should be aware of and address.
- Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upxper right of each section and then click on the respective ‘Analyze’ link.
The one for CSS is good. Use it and address the issue.
(The one for HTML misses things which is why I recommend W3C)
Just checked the code again and the W3C Validator shows no errors.
I copy/pasted all of the HTML code that you had in codepen’s HTML editor into the validator.
There are two errors. Things you should be aware of. There was no doctype declared and the
script should be before the closing
body tag, not after it. Screenshot attached…
Oh, I get what happened! When I copy my code from VS Code to Codepen, it marks the doctype line as if it wasn’t needed (to run on codepen), so I always delete that line from the code on Codepen (but not on VS Code).
I also removed the script line completely from the code when i pasted it on the validator.
I am worried about responsiveness, though. The site looks fine with a viewport set to 320px and 500px (and greater), but when i try to open it on my phone (ASUS Zenfone Max Pro M1), it doesn’t look right.
Nevermind, just fixed it by adding another media query with a breakpoint of 400px