PersonalPorfolioProject

Code Feedback
1

I’m done with the Personal Portfolio Page project which means that I’m finally done with the Responsive Web Design curriculum :heart_eyes:.

Please review and give me your honest feedback.

Thank you very much in advance.

1 Like
2

Your page looks good @nzubeifechukwu. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There is an HTML syntax error you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • User’s do not have access to your google acc’t so the images are not displaying. Codepen creates large and small screen shots of your pens that can be used in your portfolio. Access them from;
    https://codepen.io/userName/pen/slug/image/large.png (for the large screenshot)
    or
    https://codepen.io/userName/pen/slug/image/small.png (for the small screenshot)
    • where you replace userName with your codepen userId and slug with the id of one of your codepen pens and then copy that link into your portfolio
  • Do not use view port units for font sizes. The user should always be in control of the text size on the page (that is, they should be able to manually increase the text size). Using view port units prevents them from doing this. Your job as a developer is to make sure your page is responsive to text size increases. If you don’t know how to manually increase the text size, using Firefox, go to the ‘View->Zoom’ menu and activate ‘Zoom Text Only’. Then while holding down the Ctrl key scroll your middle mouse button to increase the text size. If font-sizes are defined with vw units the only way a user can increase the text size is to widen the browser window. What if the user has really bad eyesight and can’t make the browser window wide enough?
1 Like
3

Thank you, @Roma. I appreciate your detailed feedback. Will definitely apply your suggestions to make the project better.

4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.