Please share some feedback on my Tribute Page

Code Feedback
1

Hi everyone,
I’m loving freeCodeCamp so far and looking forward to improve my knowledge. Please share some feedback, this is my first page:

Also, a question: to test my codepen projects is it sufficient to open them from e.g., a mobile, from a tablet, or from a different browser?
Thank you

2

Your page looks good @Marco16168. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Review the lesson about giving meaningful text to links.
    • Web Accessibility in Mind has a more thorough explanation.
    • “wikipedia page” and “personal website” are not accessible

You can open the console and with Chrome and FF there’s a responsive design mode selector you can use to see what your page will “look” like on different devices.
Most times, it’s sufficient to just resize your browser by dragging the right edge to the left and seeing how the page responds.

3

Roma, thank you so much.

Please forgive me, my English is a little rusty and I’m not a mother-tongue. That’s why I misunderstood one of the user-story and how to include the test in the pen. I got the tests passed and I believe I got the HTML right now.
I’ve also changed the text of the links, please let me know if it is better now.

Thank you, will look into it. I was thinking more about different browsers compatibility issues though.

4

It looks good @Marco16168. Good job cleaning things up.

One thing I just noticed. It’s minor. On line 72 in your CSS you have font-size: 1.rem;
That looks like a typo. Should either be 1rem or 1.1rem or maybe some other number after the decimal. But just having the decimal w/out a number makes it look like .rem which isn’t valid.

You can find minor errors like that in codepen’s CSS by clicking on the down arrow in the upper right then click on the ‘Analyze’ link.

5

I was probably trying different font settings, leaving the dot behind.

Nice…I’m new to Codepen.

Thanks for your time Roma, you’ve been very helpful.

1 Like