Am I correct in saying this about a PR:
- Contributors should not be creating PRs from their master branch.
Do we enforce this or is it just a guideline to help the user not soil their master branch? The contribute docs seem a little vague on this I feel. First, it shows up as more of a suggestion, then later it seems more like a requirement. Is it a suggestion, or a requirement? Do we accept PRs made from the contributor’s master branch?
- The PR should only make changes to the English language files.
I seem to remember this rule being part of the contribute docs but I can’t find it in the new docs. Did we remove it/never add it in the new docs, or am I just blind?
- If the PR makes changes to multiple files it should be in one commit, if it is not, it should be squashed.
I can’t find this information in the new docs, but I believe this information was in the old docs?