Random Quote Machine - Need some feedback! :)

Code Feedback
1

Hi there! I’m developing my Random Quote Machine.

I’ve decided not use bootstrap to learn more about positioning. Despite having few elements on the page (actually 2 divs only) I learned some concepts about flexbox, which was very helpful.

I would like feedback about the page… Things I can improve and bugs so I can fix them.

Any suggestion is welcome.

Link to my Quote Machine

Best regards!

1 Like
2

I like how it’s styled :thumbsup:

I don’t know if this is an issue, but the text in the Twitter box shows entity codes instead of characters.

1 Like
3

Hey, Kev, thanks for the feedback!

This is really a problem. I think I solved this using the “decodeURIComponent” method in the quote.

$('.social-button-link').attr("href", "https://twitter.com/intent/tweet?text=" + decodeURIComponent(contentShare) + "&hashtags=" + hashtag);

Thanks again!

4

I love the styling and the use of the rotating icon. Well done!

1 Like