Tribute page completed!(First Challenge)

Code Feedback
1

I completed the first challenge!
My tribute pagehttps://codepen.io/darecoder/full/dyvVJaE
Any guidance will be appreciated :smiley:

2

Hi @Dare !

I think your page looks good.

I would review the lesson on giving links meaningful text

Wikipedia page is not that accessible.

You have a little bit of repetition in your css.
You keep repeating text-align: center;

You might consider creating a class instead of applying the same css property to individual html elements.

.bio-text {
  text-align: center;
}
1 Like
3

Welcome back @Dare. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance, links to fonts go in the box labeled ‘Stuff for <head>’
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “wikipedia page” is not accessible

Side note, user’s are not seeing your page the way you want. You have font-family: 'Roboto', sans-serif; but you neither link to it (head element in HTML) or import it (CSS).
Since you want strong you’ll want to use both normal (400) and bold (700).

1 Like
4

Thankyou @jwilkins.oboe !
I made the changes in my page according to your suggestions!
Thanks again.

1 Like
5

Thanks @Roma
I added the head info in the stuff for <head> and linked the fonts/

6

Looks good @Dare.
You don’t need to include the head tags in the box. Codepen does that for you.

Look forward to seeing your next project.
Have fun, happy coding.

7

I’ll keep that in mind.

8

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.