Tribute Page Feedback - Jun 3

Code Feedback
1

My first ever creation! I’d love some feedback for my page https://codepen.io/miscliq/full/MWpVaLZ

I’d like to know what I am missing and what I should improve. Thanks in advance! :grinning:

2

Welcome to the forums @miscliq. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 6/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance, links to fonts go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “click here” is not accessible
3

Thank you for the feedback! Sorry for the late reply.

I’ve worked on what needs to be changed. Thanks!

4

Good job cleaning things up @miscliq. Some things to revisit;

  • Run your CSS code through codepen’s validator again. Sometimes you have to do it more than once. There’s a duplicate property: value: pair you should be aware of. Be wary of having duplicates like that as they can be maintenance headaches.
  • Reread the last bullet point from my original post about accessibility. And read the links, especially the last one.
    “click here” is not accessible
5

Hi @miscliq !

Welcome to the forum!

I think your page looks good.
I wouldn’t use inline styles

<p style="font-size:25px;"

I would move that over to the css section.

Hope that helps!

6

Fixed! Thanks for the feedback @jwilkins.oboe!

7

Hi @Roma! Thanks for the feedback.

I’ve cleaned up the CSS code and I’ve made the link more accessible. Thank you for all your help!

1 Like
8

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.