Tribute page for Martin Luther King

Code Feedback
1

Good day my fellow campers I completed the tribute page for Martin Luther King Jr. a while ago :smile: feedback would be good to improve my front end development, pay no attention to the color :expressionless: https://codepen.io/akulamartin/pen/MrNVRJ

2

Nice project,
I like how you did the timeline.

3

Thanks I was planning to use bootstrap rows and columns for the timeline, I might update it again to make it neat.

4

Great choice of a person :smiley:

You should try to attach the dates and the text in a DIV or something, then use bootstrap to make it take up 12 columns and stack the DIVā€™s

iPad https://ibb.co/eqQ2Dx (768 x 1024)

The Net Ninja made a good series on bootstrap 4. Itā€™s a little out of date, but the basic of bootstrap that I use are there. I started you from tutorial #4 (skipped some installation and stuff)

I didnā€™t watch the full series, and itā€™s not a entire connected series either. Each video teaches about one thing you can do with bootstrap (blocks, margins, etc) so you can start from really any video. There also quick, and can save you a lot of time w/ getting to the point quickly.

1 Like
5

the layout is amazing and all the info is correct

6

My 2 cents: for me the timeline looks a bit cramped and therefore a bit hard to read, coz dates and text are not exactly aligned (but I understand thatā€™s just personal preference). Another thing I see is there are a lot of links in the text, but you didnā€™t add ā€œ_blankā€ to any of those, so they donā€™t open. Finally, the quote doesnā€™t show up as one, although code looks good so I really donā€™t know whatā€™s the issue. Maybe look into that?
Otherwise, itā€™s a great project.

7

Thanks for the feedback guys Iā€™ll work on the suggestions ASAP.:ok_hand:

8

Very true I was kind of in a hurry so a generated a table.2 cents are welcome :ok_hand:

1 Like