Hello friends,
I’m listening to your remarks
@ALhoucine
your page looks nice. but there some things:
- the color doesn’t match with the word " Computer Science Student"
- reduce the padding for the contact.
- mobile screen is not good
- there some spelling mistakes.
Please these changes.
Thanks,
Codely
Happy Coding
Thank you very much Codely, it’s very helpful.
actually I didn’t check the appearance for the mobile screen, I’ll do it .
Very nice portfolio. The colors really match each other well and the layout is simple and beautiful.
There are a number of suggestions that I have to make your project better.
• The portfolio isn’t very responsive. That means it is not compatible with small screen sizes. You should use some media queries to make it a bit better.
You can see in the images below how I test for phone responsivity. I highly suggest using that editor layout for better testing. You don’t really have to worry about the height of the site.
In this image (below), you can see that there is a horizontal scroll. Professional websites should not have one.
In this image (below), I am viewing your portfolio from a similar size of a phone screen. It looks seriously crammed up.
It will probably not be perfect and it doesn’t have to be. One of the hardest parts about making websites for me is making them responsive.
• In the footer where it says something about only some of the links working, I think you should replace that element with a copyright element. If you don’t want to make some of the links work, just set their href
attribute to "#"
.
At all else, great work. Happy Coding!
Thank you for your precious time ConnerOw1115. Yes, I have to improve myself and practice on responsive design.
Greetings
Your page looks good @ALhoucine. Some things to revisit;
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
body
element in HTML. (No need to include thebody
tags). For anything you want to add to the<head>
element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box. - Run your HTML code through the W3C validator.
- There are HTML coding errors you should be aware of and address.
- Remember an
id
must be unique within the document.
- Remember an
- There are HTML coding errors you should be aware of and address.
- Do not use in-line styling. Keep all your styling external
- Make your page responsive. Remember, the R in RWD stands for Responsive.
- It’s been mentioned in the previous feedback. There’s a horizontal scrollbar on large and small screens.
I would like to thank you @Roma for your contribution, I have learned a lot, that I have ignored, through these feedbacks.
Best Regards