Would appreciate some feedback

Code Feedback
1

Just completed the Personal Portfolio Page task: https://codepen.io/debiday/pen/bGVXyvb

Will appreciate feedback on my code as I know it’s not best practice!

Thank you for your time

1 Like
2

Your page looks pretty good to me. The code looks good too (you’re missing a semi colon after the color yellow in your colors selector statement in your CSS, but that’s not a big deal).

Only suggestion I have is possibly making the footer a little thinner and possibly changing the background color of your projects section or the background color of your technical documentations page because it blends into the background.

1 Like
3

Your portfolio looks good @Debiday. Some things to revisit;

  • With codepen, the link to the font(s) goes in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are HTML coding errors you should address.
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for HTML misses things which is why I recommend W3C
    • The one for CSS is good. Use it, there’s something to clean up.
    • For instance, in your colors declaration, all your property: value; pairs are like this, yellow: #F8FA90 They’re all missing the semicolon after the value

I took a look at one of your projects, the survey form. Don’t use <br> to force line breaks or spacing. That’s what CSS is for.
You also have at least one duplicate id in the form. Remember, an id must be unique within the document. To see what happens, bring up the form so you can see both the radio buttons and the checkboxes. Click on the label “other” in the checkbox section and note that the radio button “other” gets selected, not the checkbox “other”

1 Like
4

Thanks for the encouragement :star_struck:That’s a good idea with the background colour

5

Oh, you are too good with your attention to detail @Roma! I’ve done all the edits now thank you for the encouragement :blush: