https://codepen.io/bredding234/pen/QWpgQrY?editors=1100
Hi, I have a issue with #8 and #2 of personal portfolie site
https://codepen.io/bredding234/pen/QWpgQrY?editors=1100
Hi, I have a issue with #8 and #2 of personal portfolie site
Please edit your topic and give a brief, descriptive title rather than a link that cannot be clicked.
What is the issue? Is it that they are not passing?
When a test fails click the red button to see which test(s) are failing and text to help you correct the issue.
For instance, the first failing message says
My portfolio should have a link with an id of "profile-link", which opens my GitHub or FCC profile in a new tab.
#profile-link should have a target attribute : expected false to equal true
AssertionError: #profile-link should have a target attribute : expected false to equal true
Are you meeting this criteria?
On a side note, do not use the <br>
element to force line breaks or spacing. That’s what CSS is for.
https://codepen.io/bredding234/pen/QWpgQrY
I have an issue with the viewport and the height, I am rereading it and can not figure out the issue.
@bredding23, the failing test says
The height of the welcome section should be equal to the height of the viewport.
The height of #welcome-section is not equal to the height of the viewport : expected 470 to be close to 824 +/- 0
AssertionError: The height of #welcome-section is not equal to the height of the viewport : expected 470 to be close to 824 +/- 0
Granted this is not as informative as some of the other error messages but looking at your portfolio one would expect the welcome section to have more height. That is, I shouldn’t see your projects yet. The welcome section should take up the full screen.
A couple of things you can revisit;
height
property in #welcome-section
. (While changing this won’t fix the issue it’s something you should be looking at)* {
border: solid 1px lightgreen;
}
Alternately you can add this line to any of your selectors to help visualize how they’re set up. Change the color is needed.
id
must be unique to the document.On a side note, do not use the <br>
element to force line breaks or spacing. That’s what CSS is for.
Hope this helps.
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.