Interested to hear feedback for my Tribute Page project

Code Feedback
1

Hi everyone!

It’s my first time posting here and I would love to hear your feedback on my Tribute Page project.

Thank you!

2 Likes
2

Very nice :slightly_smiling_face:

1 Like
3

Nice work.

  • I noticed you use “img-responsive” class in your images.
    When checking the bootstrap documentation i found out that img-responsive was renamed to img-fluid
    (source: https://getbootstrap.com/docs/4.0/migration/#images)

  • I’m also not 100% sure if you want your very first container to be “container” instead of “container-fluid”.
    your background is white so it doesn’t really matter right now.

1 Like
4

Nice work
Alt text can be more descriptive.

1 Like
5

Thank you :slight_smile:

6

Thank you for letting me know about img-responsive class, I didn’t know about that.

7

Thank you, I will keep in my mind that alt text should be more descriptive.

1 Like
8

Nice!

Thank you for sharing.

1 Like
9

Hi Sara,

Nice choice for a tribute page. Did you watch the film “Selma” that came out a few years ago? It was pretty good!

In regards to image-responsive vs image-fluid. That was a change made in bootstrap 4. If you are using bootstrap 3, then you should use the old one. I chose to learn bootstrap 4 because I figure there is a good chance it will be standard by the time I find the developer job I’m aiming for! I’ve experienced no stability issues with bootstrap 4.

If you want to challenge yourself, I would suggest trying to change the fonts to one you really like. Google Web Fonts might help with that. Also, making the images into an image carousel using bootstrap might be a fun project. My own experience with the front end stuff on FreeCodeCamp has led me to the bootstrap documentation and the w3schools css reference more than anything else. I just started trying out random components.

Keep up the good work!

1 Like
10

thank you, @codingcarla :smiley:

11

@njordomir I really appreciate your detailed feedback.

I haven’t watched “Selma” but after you mentioned it I went on Youtube to see a movie trailer and I will definitely check it out. Great suggestion! :slight_smile:

I use Bootstrap 4 in CodePen so I will stick to image-fluid. :smiley:

I’m currently doing my Portfolio Website so I was exploring icons for contact information (such as LinkedIn, GitHub,…). Do you have any suggestions or is it better to just use an image for that?

I’m still pretty new in web development so there is so much to learn and I enjoy exploring as I’m learning.

12

I think font-awesome has some of the icons you’re looking for, and if I remember correctly they use it in at least one of the lessons/projects on FCC. That’s what I use for contact pages. It’s not hard to set up. I do think you need to sign up, but it doesn’t cost anything unless you wanted to buy the exhaustive icon set or something like that. Since they’re a font, they scale much more nicely than raster images.

I’m about halfway through my journey (by my estimate). I signed up to work on a project with a few other people to gain some more experience.

1 Like