Would appreciate some feedback on my landing page.
Great work!!, I especially love that thing you did with the text were it comes out in bits, your page looks great and is responsive on I think a tablet device right. you did a really great job.
However my observations where mainly on the codes , you had some tags that were not closed like on line 24, I recommend you use a validator to check your markup https://validator.w3.org/ before you begin styling or after your done coding the whole thing, while initializing your classes and id a space between the “=” sign and the class name or id makes your code easier to read, something like this :
<p class = "paragraph" id = "paragraph"> I am a paragraph </p>
also while wrapping tags using a convention like
<div class = "hello"> <p> Great work!!!! </p> </div>
Makes it really easy to read.
Thats all from me , thanks for sharing
Not sure what screen size you were working on. When I look at it on my screen (1920 X 1080), in Code Pen’s full screen mode, at 100%, this is what I see. Looks like you put a lot of work in. Possible next steps would be to design it to be a little more responsive.
I think it’s because of the IMG element that has an image of a lower resolution than your screen size. So, it didn’t render and that’s the reason why the text looks overlapped, when it meant to overlay the image(that couldn’t render on your screen).
Anyways, will tryna do something about the image, so all that everything falls into the right place.
Thank you, appreciate your feedback.
Thank you for your feedback and the insights.
Very nice! It seems that you’ve fixed the image issue. I tested it in full screen mode on a 1920 x 1200 monitor at 100% and it renders fine. It also scales down/wraps fine for me with no overlapping.
In addition to what okibe007 said about the markup validator, they also have a CSS validator. It is showing 2 errors and a bunch of warnings. You might want to look into that.
Here’s a link to the landing page for all of W3’s developer and validation tools:
Your landing page makes me want to buy that keyboard. As soon as I finish learning how to code well enough to get a job and make some money… maybe I will get the cheaper wired version so I don’t have to spend a lot on replacing batteries!
Thank you for the feedback.
As well as for introducing the tools to improve myself.
And I wish you the best for your journey towards becoming a Software Engineer.
I know right sick keyboard!!