Ryan Sorrentini - Portfolio Project Feedback :)

Code Feedback
1

Hi there!

I’ve been working on this for a couple of days now and I finally just finished. I tried to make a mobile-responsive portfolio page that’s similar (functionally and structurally) to FCC’s portfolio page example for the project WITHOUT looking at the example’s code at all.

Here it is! The spacing is obviously a little bit off and I wasn’t able to figure out how to blend in the contact form into the page like the example does. I tried removing the top, right and left borders and changing colors but it didn’t have the effect I wanted. I also don’t know to make the nav active state change as you scroll down the page, but I’m guessing that has to do with Javascript?

Edit: I made some changes and I realized that the hamburger navbar collapse isn’t working. I keep going over the code and I’m not entirely sure what I’m missing. I included jquery first then bootstrap toward the bottom of the html body, but it still isn’t toggling the menu when clicked in mobile display. If someone could offer some advice as to what I’m doing wrong there I’d appreciate it.

EDIT #2: Nevermind! I fixed it, added the animated scroll feature and tweaked some of the CSS & HTML

Thank you and let me know what you all think! I appreciate any kind of tips for me to do better in the future! :stuck_out_tongue:

2

I think that looks really good. Small note as someone with slight red/green colour blindness. The hot-pink / purple colour at the bottom has a strange effect, as though it is trying to be 3D. It may sound strange but it is a real effect and it is worsened by the reddish colour not having a contrasting background.
It actually makes it difficult to read your name.

3

Thank you so much for your feedback! That makes sense! I made the background darker and match the navbar to contrast more with the hot-pink color used for the anchor text on the bottom. Does this look any better to you or do you still notice the strange 3D effect?

4

Sorry for long reply time, I rarely visit the forum. Yes that has sorted it completely. :slight_smile: For me at least there are no unusual affects anymore. Glad I was able to help.

Good Luck on future projects

5

I was about to close the tab to your page when I noticed your lorem ipsum text. lol . Where does it come from and does it have a name or did you just make it up? Using it might be a bit distracting but worth a giggle.