All comments are welcome.
Hello, mitjamedo.
I have move your post to a more suitable sub-forum.
Well done, on completing the project. Some suggestions:
- On a large screen, there is a lot of blank space. Filling up this with larger text, or more styling would be nice.
- The alignment of the different sections is not uniform. It would look nice, if all of the sections were justified with one another. Especially, the checkboxes.
- The textbox appears too small.
- For the sake of being petty engagement & additional…check spelling.
Keep up the excellent work.
Just a few things:
- All inputs should have <label>s. Only some of them do right now.
- The text above/below the box is too hard to read on that background.
Hi @mitjamedo70, there are some things you should clean up on your form.
- Don’t use the
<br>
element to force spacing. Use margin and/or padding in CSS.- as an aside,
</br>
is not a valid element.
- as an aside,
- When you tested your form you may have noticed that your required ‘years of playing tennis’ is not required. Check the spelling of the word required in your HTML.
- All your styling should be external styling. I see at least one instance of in-line styling.
- As mentioned, users should be able to click on the label as well as the checkbox to select. (You’ve done it with the radio buttons.
- Change the cursor to a pointer when hovering over the submit button.
Didt all. Thanks a lot for details.
All the best!
@mitjamedo70, nice job but you’ve made a little error here;
<div class="button"
requires a closing >
Because it’s missing that >
your form’s submit button does not work and you’re failing one of the required user stories.
Be sure you thoroughly check yourself after making changes.
Great job on this form!
I would suggest that you fix the background image so that it doesn’t move when you scroll.
How do I do that?
add position:fixed;
to the background image in the css editor.
It would be better if you made the textArea tag or the comment section a little bigger. It is really small now.
The submit button isn’t submitting. Are you sure you applied the attribute action = "..."
to your <form>
tag? Did you ensure that the submit button submits the form?
Overall, great job. Keep up the great work!
Thanks a lot for comments. You are most helpfull!
I fixed SUBMIT button (> missing) and fixed position of background image by using background-attachment: fixed;.
Do I really need bigger textarea? I mean there is small button for adjusting comment box on right bottom side.
All the best!
Hey Roma!
Thanks for > on button. I fixed it!
All the best
It looks good @mitjamedo70. One last thing, why not just style the button instead of the button class?
In your CSS change .button
to button
and see what I mean. Personally, I think it looks better.
Hi Sky020!
Thanks for moving my post to sub forum. I will try to do it myself next time.
Thanks for all the comment!
All the best!
Thanks a lot!
All the best!