Please feel free to criticize my work, i am a noob that will be glad to take any advice from Pros , thank you for your time!
Hey there! Impressive job with the tribute page!
Honestly, I think you did a fantastic job, and the animated picture is a nice touch. I do have some advice that might help you:
- Run CSS and Html through the W3C Code validator, here’s the link to the Html validator: https://validator.w3.org/#validate_by_input
here’s the link for CSS http://jigsaw.w3.org/css-validator/#validate_by_input
the green background is a bit off putting; I recommend letting the background stay white or pick a new color. I am also terrible at colors so I can’t help you pick colors, but I hope this helped.
I also recommend implementing a custom font, the default font blends into the green background I recommend looking for a new font in the Google font store. I also realize that you have implemented a custom font so I think you should just change the font.
I hope these tips and insights help!
Your page looks good @bedward. Some things to revisit;
Codepen provides the boilerplate for you. It only expects the code you’d put within the
bodyelement in HTML. (No need to include the
bodytags). For anything you want to add to the
<head>element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
- The link to the font goes in the box labeled ‘Stuff for <head>’
- It’s incorrect to put the
linkto the font in the stylesheet. You
linkto the font in the
headelement of HTML, you
importthe font in the CSS stylesheet. (But as noted, if you’re going to
linkthen it goes into the stuff for head box in codepen.)
Do not use the
<br>element to force line breaks or spacing. That’s what CSS is for.
Review the lesson about giving meaningful text to links.
- Web Accessibility in Mind has a more thorough explanation.
- “wikipedia entry” is not accessible
On a side note, you don’t have to recreate the FCC projects. Make your own. As the objectives say, the ones you do only have to be ‘functionally similar’ and you should ‘give it your own style’.
Thank you very much for your advice, very appreciated!
No prob although I do admit that I missed the element problem, sorry about that!
Thank you very much for your thorough investigation of the code, very appreciated! and thanks for the advice and tips.