My first tribute page Albert Einstein

Code Feedback
1

Hi feel free to give me some feedback on my page:)https://codepen.io/benjamin3141/pen/JjRqGEV
How do I activate the run test option?

2

Hi there,welcome to the forum,your page looks good.

You can put:

<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>

at the bottom of your html code,hope that helps.

3

Welcome to the forums @businessandcodingacc. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’. They would not be in the body. Review this for an understanding of the HTML boilerplate tags.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
    • “here” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on large and small screens

On a side note, don’t be afraid to be descriptive with class and id names. It’ll be more semantic for yourself, and others who read your code. For example, if you have several two letter id's that make sense to you now, they may not a year later and probably will never mean anything to other people.

4

Hey, congratulations on your first tribute page. Try experimenting with your navigation bar colors, maybe something from blue or brownish/ black tones (like in the image). I like to upload the image I use on https://imagecolorpicker.com/. It gives nice color palette that you can use in your project.

5

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.