Personal Portfolio Grids and Other Feedback

Code Feedback
1

I’m knocking my head against the wall with this, I don’t feel prepared for this project! Anyways, I have all of the requirements dealt with, but it’s not very attractive and I cannot figure out what to do with the pictures. I’ve completely scrapped the CSS once yesterday and I just don’t know what to do at this point! I might just be too tired to tackle this, but any feedback is appreciated! Mainly, I need to figure something out with the photos/icons. I tried using aspect ratio but I couldn’t figure out how it works out when coding/calculating. Again, very tired. I will probably read replies tomorrow after I get some sleep, since I’m probably not in the right mindset to get this done efficiently. Thank you!

2

The first thing is that your icon images and divs surrounding images of your project have the same class.
Instead you should give them for example class icon
And than you can do

.icon {
 height: 5vh;
 }

The second thing is that you should have them written like this, inside the a tag

   <a href="https://github.com/jadesbeach" target="_blank" class="target-link" id="profile-link"> 
        <img class="image icon" src="https://image.flaticon.com/icons/svg/25/25231.svg" alt="Github" /></a>

In some places you forgot about adding the closing > before

It won’t make them stick to the bottom. You have to check how to make the footer or contact info at the very bottom of the page.

You should give the div pictures display flex if you want to use flex

.pictures {
  display: flex;
  flex-direction: row;
  flex-wrap: wrap;
}

Do you want to make each picture a link to something else?
If you give the div with class image for example 200px width
and then set img max-width to 100 % it starts working

.image {
  width: 200px;
}
img {
  max-width: 100%;
}

If you have more question, please ask.

1 Like
3

Thank you so much, I know I took a while to reply, just hadn’t been able to find time when I was fully awake to work on it! Your advice worked, thank you so much! I think I’m going to stop worrying so much about how it looks now, clean a few things up and turn it in, it’s time for me to move on to the next course! Thank you again!

1 Like
4

No problem. You can always come back to your project when you have more knowledge and experience and make some changes.